Add Problem Reporting API and provide Access Transformer Errors in a Machine Readable Format#50
Merged
shartte merged 6 commits intoneoforged:mainfrom May 2, 2025
Merged
Conversation
Last commit published: 10fa1ef999adccc9c9d8b45b0506c2ddd6d59b70. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #50' // https://github.com/neoforged/JavaSourceTransformer/pull/50
url 'https://prmaven.neoforged.net/JavaSourceTransformer/pr50'
content {
includeModule('net.neoforged.jst', 'jst-api')
includeModule('net.neoforged.jst', 'jst-cli')
includeModule('net.neoforged.jst', 'jst-cli-bundle')
}
}
} |
Contributor
|
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
neoforged-automation
bot
added
the
needs rebase
neoforged-automation
bot
removed
the
needs rebase
shartte
changed the title
Technici4n
reviewed
Apr 28, 2025
Matyrobbrt
requested changes
Apr 28, 2025
Member
Matyrobbrt
left a comment
Matyrobbrt
left a comment
There was a problem hiding this comment.
You did not have any of the errors in ApplyATsVisitor (that use this method) changed to the problems system.
Comment on lines
+68
to
+71
| if (e instanceof RuntimeException re) { | ||
| throw re; | ||
| } | ||
| throw new RuntimeException(e); |
Member
There was a problem hiding this comment.
I would replace this with a sneaky generic throw, not sure if we have a helper for that in JST.
Contributor
Author
There was a problem hiding this comment.
Not a friend of that hack tbh. Is there a significant issue with this wrapping?
...ormers/src/main/java/net/neoforged/jst/accesstransformers/AccessTransformersTransformer.java
Show resolved
Hide resolved
...ormers/src/main/java/net/neoforged/jst/accesstransformers/AccessTransformersTransformer.java
Outdated
Show resolved
Hide resolved
Technici4n
approved these changes
Apr 28, 2025
Matyrobbrt
requested changes
Apr 30, 2025
accesstransformers/src/main/java/net/neoforged/jst/accesstransformers/ApplyATsVisitor.java
Show resolved
Hide resolved
Matyrobbrt
approved these changes
May 2, 2025
|
🚀 This PR has been released as JavaSourceTransformer version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes a Problem Reporting API to plugins, and uses that API to report issues with access transformers.
A new CLI option can be used to get all reported problems in a JSON format.